Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-79 Register endpoints from auth manager into FastAPI #44932

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jason810496
Copy link
Contributor

closes: #44882


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be done yet.

The ticket depends on #44847 (cf issue description), which will update the provider interface and allow us to retrieve a new fastapi router to register extra routes coming from the provider.

We don't want to embed the flask legacy code into the new fastapi (That's only true for supporting legacy v2 plugins), but for the rest we want to convert them to fastapi. (convert the legacy routes to fastapi routes, expose a native fastapi router, and register that).

I think we will have to wait a little bit :)

@jason810496
Copy link
Contributor Author

Thanks for the reminder! I’ll wait until #44847 is resolved.

@jason810496 jason810496 marked this pull request as draft December 16, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register extra router from the authmanager into the FastAPI application
2 participants