Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise deprecation warning when accessing metadata through str #44791

Merged

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Dec 9, 2024

This behavior will be removed in airflow 3 as assets have attributes name and uri, it would be confusing to identify which attribute should be used to filter the right asset

related: #43922, #44639


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

airflow/datasets/metadata.py Show resolved Hide resolved
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests fail but you probably know how to fix...

@Lee-W
Copy link
Member Author

Lee-W commented Dec 10, 2024

Some tests fail but you probably know how to fix...

I'm not sure at this moment 🤔 but will take a look later today

@Lee-W Lee-W force-pushed the deprecate-metadata-string-access branch from fdd6217 to 79ac426 Compare December 10, 2024 09:52
@Lee-W Lee-W merged commit a1622eb into apache:v2-10-test Dec 10, 2024
48 checks passed
@Lee-W Lee-W deleted the deprecate-metadata-string-access branch December 10, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:dev-tools area:production-image Production image improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants