Added output_processor parameter to SQLQueryOperator and fixed bug with return_single_query_results handler when None is passed as split_statements #44781
+52
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
changed the title
BaseSQLOperator
potiuk
approved these changes
Dec 9, 2024
|
Nice. But tests have to pass :) |
dabla
changed the title
BaseSQLOperator
Yeah, that's when I discovered the bug in the return_single_query_results handler method. |
potiuk
approved these changes
Dec 9, 2024
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
…th return_single_query_results handler when None is passed as split_statements (apache#44781) * refactor: Added output_processor parameter to SQLQueryOperator * refactor: Reformatted SQLQueryOperator * refactor: Fixed return_single_query_results when none is passed as split_statements * refactor: Reformatted SQLExecuteOperator * refactor: Added white line --------- Co-authored-by: David Blain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added output_processor parameter to SQLQueryOperator to allow customizing return of results as by default descriptions get ignored. This parameter allows us to customized that if needed.
Also fixed an issue with the return_single_query_results handler method when None is passed as split_statements, which wasn't allowed in the handler method but is for the split_statements parameter in the SQLQueryOperator.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.