Remove unnecessary compatibility code in S3 asset import #44714
Merged
+5
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
jedcunningham,
eladkal and
o-nikolas
as code owners
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:amazon-aws
The S3 asset import had a conditional code to import assets but it is unnecessary, because the compatibility code is added to common.compat provider - but only in the upcoming version so we have to make sure that common.compat is added to "chicken-egg" providers, so that constaraints are properly generated for PyPI packages. This is also the case where we can bump manually provider version without waiting for release time - because we need to depend on the new provider version in amazon provider.
potiuk
force-pushed
the
fix-unnecessary-conditional-code
branch
from
148f0a9 to
00a6889
Compare
|
Extracted from #44686 - I found this unnecessary compatibility code while looing and consistency of version checks across all providers. |
eladkal
approved these changes
Dec 6, 2024
Lee-W
reviewed
Dec 6, 2024
Lee-W
approved these changes
Dec 6, 2024
Ohashiro
pushed a commit
to Ohashiro/airflow
that referenced
this pull request
Dec 6, 2024
The S3 asset import had a conditional code to import assets but it is unnecessary, because the compatibility code is added to common.compat provider - but only in the upcoming version so we have to make sure that common.compat is added to "chicken-egg" providers, so that constaraints are properly generated for PyPI packages. This is also the case where we can bump manually provider version without waiting for release time - because we need to depend on the new provider version in amazon provider.
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
The S3 asset import had a conditional code to import assets but it is unnecessary, because the compatibility code is added to common.compat provider - but only in the upcoming version so we have to make sure that common.compat is added to "chicken-egg" providers, so that constaraints are properly generated for PyPI packages. This is also the case where we can bump manually provider version without waiting for release time - because we need to depend on the new provider version in amazon provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S3 asset import had a conditional code to import assets but
it is unnecessary, because the compatibility code is added to
common.compat provider - but only in the upcoming version so we have
to make sure that common.compat is added to "chicken-egg" providers,
so that constaraints are properly generated for PyPI packages.
This is also the case where we can bump manually provider version
without waiting for release time - because we need to depend on the
new provider version in amazon provider.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.