Make AssetAliasEvent a class context.py #44709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use this class anywhere else, so it's better for it to live in this module instead. I also changed it into a simple class instead since it does not really make sense for it to be a dict. We need to do some deprecation in the 2.x branch later.
uranusjr
force-pushed
the
move-asset-alias-event
branch
from
ff8986b to
9f22672
Compare
Lee-W
approved these changes
Dec 6, 2024
Ohashiro
pushed a commit
to Ohashiro/airflow
that referenced
this pull request
Dec 6, 2024
* Make AssetAliasEvent a class context.py We don't use this class anywhere else, so it's better for it to live in this module instead. I also changed it into a simple class instead since it does not really make sense for it to be a dict. We need to do some deprecation in the 2.x branch later. * Make sure AssetAliasEvent is private * Fix deserialization * Fix type stub
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
* Make AssetAliasEvent a class context.py We don't use this class anywhere else, so it's better for it to live in this module instead. I also changed it into a simple class instead since it does not really make sense for it to be a dict. We need to do some deprecation in the 2.x branch later. * Make sure AssetAliasEvent is private * Fix deserialization * Fix type stub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use this class anywhere else, so it's better for it to live in this module instead.
I also changed it into a simple class instead since it does not really make sense for it to be a dict.
⚠️ IMPORTANT ⚠️ We need to do some deprecation in the 2.x branch later.context["outlet_events"][dataset].dataset_alias_events, the attribute is not documented anywhere (we only ever said there’sextrasavailable), and the values are not useful to users.