fix(providers/common/compat): add back add_input_dataset and add_output_dataset to NoOpCollector #44681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When the user has airflow < 2.10 installed, a provider that has not yet renamed datasets as assets (e.g.,
apache-airflow-providers-amazon==8.28.0
) andapache-airflow-providers-common-compat>=1.2.1
(with asset rename backward compatibility layer.), the user will get the followinghook_lineage_collector
after callingget_hook_lineage_collector
.As the provider has not yet been updated to use asset methods, it is still called
add_input_dataset
, which causes an AttributeError asadd_input_dataset
does not exist in the returnedNoOpCollector
What
add back
add_input_dataset
andadd_output_dataset
for backward compat^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.