AIP-84 Refactor Handling of Insert Duplicates for Post Connection #44322
+4
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason810496
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
| assert response.json() == { | ||
| "detail": f"Connection with connection_id: `{TEST_CONN_ID}` already exists", | ||
| } | ||
| assert response.json() == {"detail": "Unique constraint violation"} |
There was a problem hiding this comment.
Can we subclass the global exception handler to add personalized messages? 'Unique constraint violation' is quite broad
There was a problem hiding this comment.
It is possible to include error details (e.g., str(e)) to provide a more descriptive message. However, I can't think of a way to include custom error messages specific to each router, as the error handler is registered at the app level rather than the router level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #44121 (comment)
It seems that only the Post Connection endpoint has an extra query to handle duplicate entries. Other
409_CONFLICTcases don't handle inserting duplicate entries on unique constraint columns.