[v2-10-test] Only install eval-type-backport for Python < 3.10 (#44294) #44315
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e#44294) The `eval-type-backport` is a tool to replace some of the controversial new type hints added with `from future imoport __annotations__` to "classic" type hint (| and list - into `Union` and `List`). This helps to battle some of the issues where Pydantic has troubles when they are used for classes that Pydantic uses. The library was initially added in apache#42196 but it was added for all Python versions - this change limits it only to Python < 3.10 (cherry picked from commit 2948338) Co-authored-by: Jarek Potiuk <[email protected]>
potiuk
requested review from
amoghrajesh,
pierrejeambrun,
jscheffl and
bugraoz93
|
I am cherry-picking that one to 2-10-test - targetting for 2.10.4 - just in case pydantic/pydantic#10958 will not be quickly resolved and Pydantic team will be reluctant to make |
bugraoz93
approved these changes
Nov 24, 2024
|
I believe failed steps are not relevant to the changes. It seems like a couple of tests are still using old configuration. |
Yeah, we need to fix it separately. |
jscheffl
approved these changes
Nov 24, 2024
utkarsharma2
added
the
changelog:skip
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 4, 2024
… (#44315) The `eval-type-backport` is a tool to replace some of the controversial new type hints added with `from future imoport __annotations__` to "classic" type hint (| and list - into `Union` and `List`). This helps to battle some of the issues where Pydantic has troubles when they are used for classes that Pydantic uses. The library was initially added in #42196 but it was added for all Python versions - this change limits it only to Python < 3.10 (cherry picked from commit 2948338)
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 9, 2024
… (#44315) The `eval-type-backport` is a tool to replace some of the controversial new type hints added with `from future imoport __annotations__` to "classic" type hint (| and list - into `Union` and `List`). This helps to battle some of the issues where Pydantic has troubles when they are used for classes that Pydantic uses. The library was initially added in #42196 but it was added for all Python versions - this change limits it only to Python < 3.10 (cherry picked from commit 2948338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eval-type-backportis a tool to replace some of the controversial new type hints added withfrom future imoport __annotations__to "classic" type hint (| and list - intoUnionandList).This helps to battle some of the issues where Pydantic has troubles when they are used for classes that Pydantic uses.
The library was initially added in #42196 but it was added for all Python versions - this change limits it only to Python < 3.10 (cherry picked from commit 2948338)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.