Make task output "unbuffered" so output is captured straight away #44186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change a dag like this: ``` @task() def hello(): print("hello") time.sleep(300) print("goodbye") ``` would not show the output for "hello" until after the sleep! This is analogouys to setting PYTHONUNBUFFERED environment variable when running something like `python script.py | cat` etc.
ashb
added
area:task-execution-interface-aip72
eladkal
approved these changes
Nov 19, 2024
amoghrajesh
approved these changes
Nov 19, 2024
| print("stderr message", file=sys.stderr) | ||
| sys.stderr.flush() | ||
| # We need a short sleep for the main process to process things. I worry this timining will be |
There was a problem hiding this comment.
Suggested change
| # We need a short sleep for the main process to process things. I worry this timining will be | |
| # We need a short sleep for the main process to process things. I worry this timing will be |
There was a problem hiding this comment.
Whoops, just missed this by a few seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change a dag like this:
would not show the output for "hello" until after the sleep!
This is analogouys to setting PYTHONUNBUFFERED environment variable when
running something like
python script.py | catetc.