Move trigger dagrun to standard provider #44030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardeybisey
requested review from
potiuk,
ashb and
bolkedebruin
as code owners
boring-cyborg
bot
added
area:core-operators
This is mostly pointless but hey. I didn't want to write log because there's often a log var. I was annoyed that pre-commit was complaining about this so I just noqa'd it. But what Kaxil wants, Kaxil gets ;)
* add clear_dag_run * add tests * Merge branch 'main' of https://github.com/apache/airflow into kalyan/API-84/clear_dag_run * add ti response * add * use logical_date * fix tests * remove async * Update airflow/api_fastapi/core_api/routes/public/dag_run.py Co-authored-by: Pierre Jeambrun <[email protected]> * Update airflow/api_fastapi/core_api/datamodels/dag_run.py Co-authored-by: Pierre Jeambrun <[email protected]> * remove type ignore * update ti state and assert it * reuse state * remove breakpoint * feedback --------- Co-authored-by: Pierre Jeambrun <[email protected]>
The tests execution was traditionally using single "breeze testing tests" command and you could select which test to run via TEST_TYPE. However the recent move of providers and adding task_sdk necessitates splitting the tests commands into separate commands for core, providers, task_sdk, helm, integration and system. This is done via introducing "TEST_GROUP" - which determines which group of tests is being executed, and dedicated testing command for each of the groups - with "db" and "non-db" variants where applicable. Cleanup and small refactoring has been done to make it easier to reason about parameters passed down from the command line to docker and in-container pytest command. Related: apache#42632
Co-authored-by: Tzu-ping Chung <[email protected]>
hardeybisey
requested review from
jedcunningham,
mobuchowski,
eladkal,
o-nikolas,
josh-fell,
hussein-awala,
uranusjr,
bbovenzi,
pierrejeambrun,
ryanahamilton and
jscheffl
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving trigger_dagrun operator to standard provider.
airflow/operators/trigger_dagrun.py >> providers/src/airflow/providers/standard/operators/trigger_dagrun.py^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.