Fix System test type in breeze #43670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the behaviour of the `System` test type in Breeze testing tests. Remove the path appending to the beginning of the breeze command (because as we've discussed before with the reorganization of our test directories this creates a non-top level loading of a pytest plugin which pytest disallows). This allow us to still specify the System test type because that option controls other beahviours we need (like disabling db init).
o-nikolas
requested review from
potiuk,
ashb and
jedcunningham
as code owners
potiuk
approved these changes
Nov 5, 2024
|
The "standard" python issue with docs is caused by unrelated issue, we will fix it separately. Yeah - it looks like a good band-aid for now. I will fix it during #42632 (I already have a draft). I will also add a separate test to test sytem tests in CI as part of it, so that it will not happen in the future |
sunank200
pushed a commit
to astronomer/airflow
that referenced
this pull request
Nov 5, 2024
* Fix System test type in breeze Adjust the behaviour of the `System` test type in Breeze testing tests. Remove the path appending to the beginning of the breeze command (because as we've discussed before with the reorganization of our test directories this creates a non-top level loading of a pytest plugin which pytest disallows). This allow us to still specify the System test type because that option controls other beahviours we need (like disabling db init). * Fix unit test
topherinternational
pushed a commit
to topherinternational/airflow
that referenced
this pull request
Nov 5, 2024
* Fix System test type in breeze Adjust the behaviour of the `System` test type in Breeze testing tests. Remove the path appending to the beginning of the breeze command (because as we've discussed before with the reorganization of our test directories this creates a non-top level loading of a pytest plugin which pytest disallows). This allow us to still specify the System test type because that option controls other beahviours we need (like disabling db init). * Fix unit test
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Fix System test type in breeze Adjust the behaviour of the `System` test type in Breeze testing tests. Remove the path appending to the beginning of the breeze command (because as we've discussed before with the reorganization of our test directories this creates a non-top level loading of a pytest plugin which pytest disallows). This allow us to still specify the System test type because that option controls other beahviours we need (like disabling db init). * Fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the behaviour of the
Systemtest type in Breeze testing tests. Remove the path appending to the beginning of the breeze command (because as we've discussed before with the reorganization of our test directories this creates a non-top level loading of a pytest plugin which pytest disallows). This allow us to still specify the System test type because that option controls other beahviours we need (like disabling db init).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.