Fix Try Selector in Mapped Tasks also on Index 0 #43590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
jscheffl
added
type:bug-fix
bbovenzi
reviewed
Nov 1, 2024
Co-authored-by: Brent Bovenzi <[email protected]>
bbovenzi
approved these changes
Nov 1, 2024
jscheffl
added a commit
that referenced
this pull request
Nov 1, 2024
…43591) * Fix Try Selector in Mapped Tasks also on Index 0 (cherry picked from commit 1c3d555) * Review Feedback, direct commit Co-authored-by: Brent Bovenzi <[email protected]> --------- Co-authored-by: Brent Bovenzi <[email protected]>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Fix Try Selector in Mapped Tasks also on Index 0 * Review Feedback, direct commit Co-authored-by: Brent Bovenzi <[email protected]> --------- Co-authored-by: Brent Bovenzi <[email protected]>
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 4, 2024
…43591) * Fix Try Selector in Mapped Tasks also on Index 0 (cherry picked from commit 1c3d555) * Review Feedback, direct commit Co-authored-by: Brent Bovenzi <[email protected]> --------- Co-authored-by: Brent Bovenzi <[email protected]>
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing a regression on release tests on 2.10.3rc2 I noticed that the fixed logic still has a problem on mapped in dex 0 - seem I did not click on the first mapped element when testing :-(
This PR fixes the logic such that the try history is correctly fetched also for index 0 if dynamic mapped tasks.
Hope we get rid of this code in Airflow 3, this manual client function is really error prone.
related: #43565 #42357