-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "/" in metrics validator #42934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s,file_path=/mnt/c
Two asks:
|
potiuk
approved these changes
Nov 28, 2024
Some static checks to fix. I recommend installing pre-commit - it will solve problems for you |
potiuk
approved these changes
Nov 30, 2024
Nice! |
Very nice indeed, thank you so very much. @potiuk will this be backported and included in 2.10.3 or only in a future Airflow v3? |
Ah ... It should be .. but I forgot to put the label on it... So let me try to cherry-pick it now. |
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Nov 30, 2024
* Allow "/" to avoid ERROR - Invalid stat name: dag_processing.processes,file_path=/mnt/c * Add UT * Reformat (cherry picked from commit 14b32ea) Co-authored-by: awdavidson <[email protected]>
potiuk
added a commit
that referenced
this pull request
Nov 30, 2024
* Allow "/" to avoid ERROR - Invalid stat name: dag_processing.processes,file_path=/mnt/c * Add UT * Reformat (cherry picked from commit 14b32ea) Co-authored-by: awdavidson <[email protected]>
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 4, 2024
* Allow "/" to avoid ERROR - Invalid stat name: dag_processing.processes,file_path=/mnt/c * Add UT * Reformat (cherry picked from commit 14b32ea) Co-authored-by: awdavidson <[email protected]>
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Allow "/" to avoid ERROR - Invalid stat name: dag_processing.processes,file_path=/mnt/c * Add UT * Reformat (cherry picked from commit 14b32ea) Co-authored-by: awdavidson <[email protected]>
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
* Allow "/" to avoid ERROR - Invalid stat name: dag_processing.processes,file_path=/mnt/c * Add UT * Reformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed in this PR
closes: #30716
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.