Convert numpy types to their native python types #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know exactly why but for some reason the json encoder in python3 can't encode some of the numpy datetypes. Now I simply converted the numpy data types (http://docs.scipy.org/doc/numpy/user/basics.types.html) to the respective python types.
| @@ -29,6 +29,8 @@ | |||
| from sqlalchemy import event, exc | |||
| from sqlalchemy.pool import Pool | |||
|
|
|||
| import numpy | |||
There was a problem hiding this comment.
It's pretty standard to do import numpy as np, then it'll help with respecting the 80 char per line limit we've been following to stay in line with PEP8 when possible.
|
@mistercrunch done! |
|
Thanks! |
mistercrunch
added a commit
that referenced
this pull request
Sep 24, 2015
Convert numpy types to their native python types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know exactly why but for some reason the json encoder in python3 can't encode some of the numpy datetypes. Now I simply converted the numpy data types (http://docs.scipy.org/doc/numpy/user/basics.types.html) to the respective python types. (#416)