-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix oracle bulk insert issue when leftover chunk is empty #42606
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
f09e6b7
to
ee4ddd5
Compare
Could you please add unit test for that one? |
From what I looked, So this if statement has no effect. |
Here if size of rows is equal to (or a multiple of) commit_every, then on the last iteration of the loop, row_count = 0
# Chunk the rows
row_chunk = []
for row in rows:
row_chunk.append(row)
row_count += 1
if row_count % commit_every == 0:
cursor.prepare(prepared_stm)
cursor.executemany(None, row_chunk)
conn.commit() # type: ignore[attr-defined]
self.log.info("[%s] inserted %s rows", table, row_count)
# Empty chunk
row_chunk = [] |
Oh I missed this, thanks! |
In bulk_insert_rows method of oracle hook, if number of rows is equal to chunk size, then leftover of chunk is 0, and code will fail, I've just checked the size of leftover before executing query.