Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oracle bulk insert issue when leftover chunk is empty #42606

Closed
wants to merge 1 commit into from

Conversation

mfatemipour
Copy link
Contributor

@mfatemipour mfatemipour commented Oct 1, 2024


In bulk_insert_rows method of oracle hook, if number of rows is equal to chunk size, then leftover of chunk is 0, and code will fail, I've just checked the size of leftover before executing query.

Copy link

boring-cyborg bot commented Oct 1, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Oct 2, 2024

Could you please add unit test for that one?

@romsharon98
Copy link
Contributor

romsharon98 commented Oct 27, 2024

From what I looked, row_chunk can be empty only if rows is empty and that cannot happen because an exception will be raised.

So this if statement has no effect.

@mfatemipour
Copy link
Contributor Author

Here if size of rows is equal to (or a multiple of) commit_every, then on the last iteration of the loop,if statement will be executed and row_chunk will get empty.

        row_count = 0
        # Chunk the rows
        row_chunk = []
        for row in rows:
            row_chunk.append(row)
            row_count += 1
            if row_count % commit_every == 0:
                cursor.prepare(prepared_stm)
                cursor.executemany(None, row_chunk)
                conn.commit()  # type: ignore[attr-defined]
                self.log.info("[%s] inserted %s rows", table, row_count)
                # Empty chunk
                row_chunk = []

@romsharon98
Copy link
Contributor

Here if size of rows is equal to (or a multiple of) commit_every, then on the last iteration of the loop,if statement will be executed and row_chunk will get empty.

        row_count = 0
        # Chunk the rows
        row_chunk = []
        for row in rows:
            row_chunk.append(row)
            row_count += 1
            if row_count % commit_every == 0:
                cursor.prepare(prepared_stm)
                cursor.executemany(None, row_chunk)
                conn.commit()  # type: ignore[attr-defined]
                self.log.info("[%s] inserted %s rows", table, row_count)
                # Empty chunk
                row_chunk = []

Oh I missed this, thanks!
I added a tests to this PR with cherry-pick from your commit so it can be merged.
#43467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants