Deprecate DAG.run method #42417
Merged
Deprecate DAG.run method #42417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method relies on local backfill mode, which is slated for removal in 3.0. We have suitable alternatives such as DAG.test() and triggering dags via API.
|
Should it be done in |
|
I think that the practice is, add to main first, then cherry pick. But I could be wrong. |
|
That works too :) |
vincbeck
approved these changes
Sep 23, 2024
jscheffl
approved these changes
Sep 23, 2024
kaxil
approved these changes
Sep 23, 2024
|
cc @ephraimbuddy / @utkarsharma2 If we do release 2.10.3 -- worth including it then or directly in 2.11 |
Yeah I had to. These are actually very old tests. And it sorta wasn't clear what they were testing. But they are related to this issue #1225. Ultimately though, they only test behavior of the backfill scheduler, which is going to be removed, so the tests can safely be removed IMHO. And I've added a todo for that to remove them along with DAG.run. |
jedcunningham
approved these changes
Sep 23, 2024
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
This method relies on local backfill mode, which is slated for removal in 3.0. We have suitable alternatives such as DAG.test() and triggering dags via API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method relies on local backfill mode, which is slated for removal in 3.0. We have suitable alternatives such as DAG.test() and triggering dags via API.