-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow dataset alias to add more than one dataset events #42189
Merged
Lee-W
merged 3 commits into
apache:main
from
astronomer:allow-multiple-dataset-alias-events
Sep 16, 2024
Merged
allow dataset alias to add more than one dataset events #42189
Lee-W
merged 3 commits into
apache:main
from
astronomer:allow-multiple-dataset-alias-events
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
requested review from
kaxil,
ashb,
bolkedebruin and
XD-DENG
as code owners
September 12, 2024 00:35
Lee-W
requested review from
uranusjr and
sunank200
and removed request for
ashb,
bolkedebruin,
kaxil and
XD-DENG
September 12, 2024 00:37
Lee-W
force-pushed
the
allow-multiple-dataset-alias-events
branch
from
September 12, 2024 05:16
afb3f9c
to
9ef6820
Compare
2 tasks
uranusjr
reviewed
Sep 12, 2024
uranusjr
reviewed
Sep 12, 2024
uranusjr
reviewed
Sep 12, 2024
uranusjr
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General idea looks good to me, some notes on implementation.
Lee-W
force-pushed
the
allow-multiple-dataset-alias-events
branch
from
September 12, 2024 19:46
9ef6820
to
bf648e9
Compare
…ialization backward compatibility
…n in OutletEventAccessor handle the deduplication in taskinstance all at once
Lee-W
force-pushed
the
allow-multiple-dataset-alias-events
branch
from
September 12, 2024 21:19
e38cf28
to
35c5651
Compare
uranusjr
approved these changes
Sep 16, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 16, 2024
(cherry picked from commit a5d0a63)
utkarsharma2
added a commit
that referenced
this pull request
Sep 16, 2024
) (cherry picked from commit a5d0a63) Co-authored-by: Wei Lee <[email protected]>
utkarsharma2
added a commit
that referenced
this pull request
Sep 17, 2024
) (cherry picked from commit a5d0a63) Co-authored-by: Wei Lee <[email protected]>
gopidesupavan
pushed a commit
to gopidesupavan/airflow
that referenced
this pull request
Sep 17, 2024
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#34206 (comment)
could be confusing if only the second one create a dataset event
What
Save all the datasets when
add
is invoked.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.