Fix details tab log url detection #42104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
|
Needs to be backported |
potiuk
approved these changes
Sep 9, 2024
pierrejeambrun
force-pushed
the
url-detection-details-log
branch
from
3d845fb
to
34ead8d
Compare
ashb
approved these changes
Sep 9, 2024
|
Just added a test as well. There's a couple of html entity decimal code involved for the assertion to escape the |
ephraimbuddy
approved these changes
Sep 9, 2024
Nice. Very apt. |
pierrejeambrun
added a commit
to astronomer/airflow
that referenced
this pull request
Sep 9, 2024
* Fix details tab log url detection * Add test (cherry picked from commit b543932)
potiuk
pushed a commit
that referenced
this pull request
Sep 9, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same regexp that we have for the legacy log page which is more complex and robust. This will also enforce consistancy between the two pages. Cf screenshot the url was not properly matched,
!((was causing trouble.Before
After