Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower down universal-pathlib minimum to 0.2.2 (#41939) #41943

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Sep 2, 2024

Beacause we pinned universal-pathlib to 0.2.2 in 2.10.0 adding >= 0.2.3 conflicts with currently released PyPI packages. We shoudl lower it down in order to allow PyPI constraints to not be conflicting

(cherry picked from commit 351961c)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Beacause we pinned universal-pathlib to 0.2.2 in 2.10.0 adding >=
0.2.3 conflicts with currently released PyPI packages. We shoudl
lower it down in order to allow PyPI constraints to not be
conflicting

(cherry picked from commit 351961c)
@potiuk
Copy link
Member Author

potiuk commented Sep 2, 2024

Backport of #41939

@potiuk potiuk modified the milestone: Airflow 2.10.2 Sep 2, 2024
@potiuk
Copy link
Member Author

potiuk commented Sep 2, 2024

If we manage to merge it before release of 2.10.1 - that one could go to 2.10.1 @utkarsharma2 - It would be actually great because the == pinning that we have in 2.10.0 is likely a bad idea for all kinds of constraint generation.

@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.1 milestone Sep 2, 2024
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Sep 2, 2024
@utkarsharma2
Copy link
Contributor

If we manage to merge it before release of 2.10.1 - that one could go to 2.10.1 @utkarsharma2 - It would be actually great because the == pinning that we have in 2.10.0 is likely a bad idea for all kinds of constraint generation.

Sure @potiuk, I too think we should include it. I will just wait for this PR to be merged.

@potiuk
Copy link
Member Author

potiuk commented Sep 2, 2024

Ah we need also the other backport first :( (removed override param)

@potiuk
Copy link
Member Author

potiuk commented Sep 2, 2024

#41938

@potiuk potiuk removed this from the Airflow 2.10.1 milestone Sep 2, 2024
@potiuk potiuk merged commit 45a510b into apache:v2-10-test Sep 2, 2024
3 checks passed
@potiuk potiuk deleted the lower-down-universal-pathlib branch September 2, 2024 07:01
@potiuk
Copy link
Member Author

potiuk commented Sep 2, 2024

Merged both

@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.1 milestone Sep 2, 2024
@utkarsharma2 utkarsharma2 added type:misc/internal Changelog: Misc changes that should appear in change log and removed changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) labels Sep 2, 2024
utkarsharma2 pushed a commit that referenced this pull request Sep 2, 2024
Beacause we pinned universal-pathlib to 0.2.2 in 2.10.0 adding >=
0.2.3 conflicts with currently released PyPI packages. We shoudl
lower it down in order to allow PyPI constraints to not be
conflicting

(cherry picked from commit 351961c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants