Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry logic in the scheduler for updating trigger timeouts in case of deadlocks. #41429

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Add retry logic in the scheduler for updating trigger timeouts in case of deadlocks. #41429

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b44753b
Add retry in update trigger timeout
TakawaAkirayo Aug 13, 2024
ed141e8
add ut for these cases
TakawaAkirayo Aug 17, 2024
9fe33ee
use OperationalError in ut to describe deadlock scenarios
TakawaAkirayo Aug 17, 2024
fd7044b
[MINOR] add newsfragment for this PR
TakawaAkirayo Sep 29, 2024
2c6be65
[MINOR] refactor UT for mypy check
TakawaAkirayo Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions airflow/jobs/scheduler_job_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1921,21 +1921,23 @@ def adopt_or_reset_orphaned_tasks(self, session: Session = NEW_SESSION) -> int:
@provide_session
def check_trigger_timeouts(self, session: Session = NEW_SESSION) -> None:
"""Mark any "deferred" task as failed if the trigger or execution timeout has passed."""
num_timed_out_tasks = session.execute(
update(TI)
.where(
TI.state == TaskInstanceState.DEFERRED,
TI.trigger_timeout < timezone.utcnow(),
)
.values(
state=TaskInstanceState.SCHEDULED,
next_method="__fail__",
next_kwargs={"error": "Trigger/execution timeout"},
trigger_id=None,
)
).rowcount
if num_timed_out_tasks:
self.log.info("Timed out %i deferred tasks without fired triggers", num_timed_out_tasks)
for attempt in run_with_db_retries(logger=self.log):
with attempt:
shahar1 marked this conversation as resolved.
Show resolved Hide resolved
num_timed_out_tasks = session.execute(
update(TI)
.where(
TI.state == TaskInstanceState.DEFERRED,
TI.trigger_timeout < timezone.utcnow(),
)
.values(
state=TaskInstanceState.SCHEDULED,
next_method="__fail__",
next_kwargs={"error": "Trigger/execution timeout"},
trigger_id=None,
)
).rowcount
if num_timed_out_tasks:
self.log.info("Timed out %i deferred tasks without fired triggers", num_timed_out_tasks)

# [START find_zombies]
def _find_zombies(self) -> None:
Expand Down