Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing DateTimeSensorAsync, FileSensor and TimeSensorAsync to start execution from trigger during dynamic task mapping #41182

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Aug 1, 2024

Adding argument trigger_kwargs to DateTimeSensorAsync, FileSensor, and TimeSensorAsync allows them to start execution from trigger during dynamic task mapping. This PR also rewords and adds more detail to the start execution from the trigger during the dynamic task mapping section and reorders the paragraphs on that page.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W Lee-W requested a review from potiuk as a code owner August 1, 2024 09:59
@boring-cyborg boring-cyborg bot added area:core-operators Operators, Sensors and hooks within Core Airflow kind:documentation labels Aug 1, 2024
@Lee-W Lee-W force-pushed the add-start-from-trigger-with-dynamic-support-to-core-sensors branch from afd81da to d80dd1b Compare August 1, 2024 10:00
@Lee-W Lee-W changed the title Add start from trigger with dynamic support to core sensors Allowing DateTimeSensorAsync, FileSensor and TimeSensorAsync to start execution from trigger during dynamic task mapping Aug 1, 2024
…t to starting execution from trigger feature
…leSensor and TimeSensorAsync

Sdd start execution from trigger during dynamic task mapping
@Lee-W Lee-W force-pushed the add-start-from-trigger-with-dynamic-support-to-core-sensors branch from 3aa7027 to f20ea90 Compare August 1, 2024 12:32
Copy link
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lee-W Lee-W merged commit b28e8bf into apache:main Aug 1, 2024
48 checks passed
@Lee-W Lee-W deleted the add-start-from-trigger-with-dynamic-support-to-core-sensors branch August 1, 2024 13:20
@utkarsharma2 utkarsharma2 added the type:improvement Changelog: Improvements label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow kind:documentation type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants