Remove incremental upper-bind limit #41075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
added
the
full tests needed
Is there any reason for that? yanking should be safe without the need to exclude the versions if I am not mistaken 🤔 |
Yeah. It is, but ... well they could be unyanked :D |
potiuk
force-pushed
the
check-incremental
branch
from
e0716d4 to
e06cf32
Compare
|
The https://pypi.org/project/incremental/24.7.2/ released - 24.7.1 not yanked yet, so I prefer to keep the exclusions @hussein-awala |
|
Would love to merge it :) |
The twisted/incremental#106 issue has been addressed in 24.7.2 so we are removing the limit - just in case we also exclude the buggy versions, even if they are yanked.
potiuk
force-pushed
the
check-incremental
branch
from
e06cf32 to
db47bc8
Compare
|
Yeah as discussed with the author in twisted/incremental#106 (comment) they might not want to yank this version - so it's good for us to exclude them |
hussein-awala
approved these changes
Jul 31, 2024
eladkal
approved these changes
Jul 31, 2024
bjankie1
pushed a commit
to bjankie1/airflow
that referenced
this pull request
Aug 18, 2024
The twisted/incremental#106 issue has been addressed in 24.7.2 so we are removing the limit - just in case we also exclude the buggy versions, even if they are yanked.
bjankie1
pushed a commit
to bjankie1/airflow
that referenced
this pull request
Aug 18, 2024
The twisted/incremental#106 issue has been addressed in 24.7.2 so we are removing the limit - just in case we also exclude the buggy versions, even if they are yanked.
bjankie1
pushed a commit
to bjankie1/airflow
that referenced
this pull request
Aug 18, 2024
The twisted/incremental#106 issue has been addressed in 24.7.2 so we are removing the limit - just in case we also exclude the buggy versions, even if they are yanked.
molcay
pushed a commit
to VladaZakharova/airflow
that referenced
this pull request
Sep 16, 2024
The twisted/incremental#106 issue has been addressed in 24.7.2 so we are removing the limit - just in case we also exclude the buggy versions, even if they are yanked.
molcay
pushed a commit
to VladaZakharova/airflow
that referenced
this pull request
Sep 17, 2024
The twisted/incremental#106 issue has been addressed in 24.7.2 so we are removing the limit - just in case we also exclude the buggy versions, even if they are yanked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The twisted/incremental#106 issue has been addressed in 24.7.2 so we are removing the limit - just in case we also exclude the buggy versions, even if they are yanked.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.