-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable rendering for doc_md #40522
Disable rendering for doc_md #40522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we should add a condition for file paths, like reading the file without render the content
if doc_md.endswith(".md"):
return open(doc_md, "r").read()
with a try/except in case the file is not found.
f6f0110
to
e4d7197
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e4d7197
to
90109c0
Compare
90109c0
to
732a0e2
Compare
Changed a test case after approval. I'm planning on merging this late too night. Please let me know if anyone want to take a look |
LGTM. Marked it as 2.9.3 |
(cherry picked from commit 8159f6e)
(cherry picked from commit 8159f6e)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.