Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecations in API tests #40249

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

boraberke
Copy link
Contributor

@boraberke boraberke commented Jun 14, 2024

This PR resolves internal warnings under tests/api_connexion.

Test Class Issue Resolution
TestGetConnection Encountered non-JSON in extra field Reformatted them as JSON
TestPatchConnection Encountered non-JSON in extra field Reformatted them as JSON
TestSetDagRunNote The experimental REST API is deprecated Removed this test. This test is already covered via another test test_with_auth_role_public_set
TestGetExtraLinks BigQueryExecuteQueryOperator has been deprecated Used CustomOperator instead
TestGetTaskInstancesBatch get_accessible_dag_ids has been deprecated Changed to get_auth_manager().get_permitted_dag_ids
TestConnectionSchema Encountered non-JSON in extra field Reformatted them as JSON

P.S. I was not sure if I needed to open a separate PR for the fix of TestGetTaskInstancesBatch, as it involves a change in the codebase. I included it here to address all API-related test deprecations at once. Let me know if I should separate it, and I will remove it from this PR and create a new one.

related: #38642


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jun 14, 2024
@boraberke
Copy link
Contributor Author

Seems like the tests are failing with a random error similar to #40199.

@boraberke
Copy link
Contributor Author

Hi @Taragolis, did you have a chance to look at this PR? Would appreciate your comments!

@potiuk
Copy link
Member

potiuk commented Jul 4, 2024

P.S. I was not sure if I needed to open a separate PR for the fix of TestGetTaskInstancesBatch

This is fine.

@potiuk potiuk merged commit 25ab6e3 into apache:main Jul 4, 2024
52 checks passed
@utkarsharma2 utkarsharma2 added the type:misc/internal Changelog: Misc changes that should appear in change log label Jul 12, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.0 milestone Jul 12, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
* Resolve deprecations in `API` tests

* Remove experimental api test inside stable api test
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:misc/internal Changelog: Misc changes that should appear in change log labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants