-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix import future annotations in venv jinja template #40208
Fix import future annotations in venv jinja template #40208
Conversation
3a4739b
to
0a630a7
Compare
f5372a0
to
60192ac
Compare
The test will have to be skipped on airflow pre 2.10 because it will not work there (See failing compatibility tests) and ways how to deal with the compatibility issues: https://github.com/apache/airflow/blob/main/contributing-docs/testing/unit_tests.rst#implementing-compatibility-for-provider-tests-for-older-airflow-versions |
f1b5241
to
b2edec0
Compare
b2edec0
to
da9afe2
Compare
First, I changed the test to only work with Should I change the test location and remove the |
Changed the location, as it affects venv operator. |
80afd4c
to
32876b9
Compare
It passes all the tests, but maybe there's a problem with the wrong label. |
Ah yeah - now it's not a "docker provider" test - it runs only in 'airflow core` and that's correct, because it affects all the decorators not only docker, and it should not be "provider" test as it was before. |
(cherry picked from commit d5a7544)
The following
Task
, when rendered as a jinja template, will result in an error becauseAny
is not importedChanging it to a string like this will solve this problem, but it's a bit cumbersome.
It would be much easier if I could check if
annotations
is imported when rendering withjinja
.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.