Support checking for db path absoluteness on Windows #40069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev-iL
force-pushed
the
Dev-iL/202406/abs_db_path_win
branch
2 times, most recently
from
8d2e611
to
8b496e6
Compare
uranusjr
reviewed
Jun 6, 2024
Dev-iL
force-pushed
the
Dev-iL/202406/abs_db_path_win
branch
2 times, most recently
from
f3aaaef
to
2ad2d04
Compare
Dev-iL
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
Dev-iL
force-pushed
the
Dev-iL/202406/abs_db_path_win
branch
4 times, most recently
from
c9596e7
to
158c02c
Compare
uranusjr
reviewed
Jun 7, 2024
uranusjr
reviewed
Jun 7, 2024
Dev-iL
force-pushed
the
Dev-iL/202406/abs_db_path_win
branch
9 times, most recently
from
d793adb
to
dee3d97
Compare
uranusjr
approved these changes
Jun 11, 2024
Dev-iL
force-pushed
the
Dev-iL/202406/abs_db_path_win
branch
from
dee3d97
to
4ceed80
Compare
Dev-iL
force-pushed
the
Dev-iL/202406/abs_db_path_win
branch
from
4ceed80
to
8e5c85f
Compare
potiuk
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #10388
Airflow isn't supported on Windows at the moment. However, various components of Airflow work perfectly fine when given the chance. I have a use case where I'm running a unit test that involve creating a
DagBag. When running this on Windows, Airflow exits prematurely due to how absolute db paths are determined. Interestingly, when disabling the check, thus allowing Airflow to "do its thing", theDagBagis created correctly and the test suite passes.The proposed change adds support for testing path absoluteness on Windows systems.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.