AIP-61 - Add executor field to the task instance API #40034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return executor as part of TaskInstance queries and also enable filtering by executor field. Also use the changes to display the executor field on the TaskInstance Details web page.
o-nikolas
requested review from
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:API
o-nikolas
commented
Jun 4, 2024
uranusjr
approved these changes
Jun 4, 2024
o-nikolas
changed the title
|
I'm not sure why some provider tests are failing around fab imports/tests. I didn't modify anything around there. But this is my first API changes so perhaps someone else knows? CC @bbovenzi, you and I chatted about this change a couple weeks back |
shubham22
reviewed
Jun 4, 2024
vincbeck
approved these changes
Jun 4, 2024
syedahsn
reviewed
Jun 5, 2024
potiuk
reviewed
Jun 13, 2024
potiuk
approved these changes
Jun 13, 2024
|
Looks good - with one NIT - we should at least discuss if we need an index, as per discussion in https://lists.apache.org/thread/sg08mcdmvvtrwpd5cccpkl198do0xlc6 |
|
It looks like the failing test was resolved in #39899. This should be good to merge @o-nikolas? |
|
Please rebase first. |
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Return executor as part of TaskInstance queries and also enable filtering by executor field. Also use the changes to display the executor field on the TaskInstance Details web page. Co-authored-by: Vincent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return executor as part of TaskInstance queries and also enable filtering by executor field.
Also use the changes to display the executor field on the TaskInstance Details web page.
Some screenshots of the API working both with curl and in the weberver task instance details page:
First task run with an executor overridden to "apple" (an example alias):
Second task run without an executor override (so the default executor is used):
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.