Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a join for TI notes in TI batch API endpoint #40028

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Use a join for TI notes in TI batch API endpoint #40028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d20525d
Use a join for TI notes in TI batch API endpoint
jedcunningham Jun 3, 2024
38ae8bc
Merge branch 'main' into fix_join_in_batch_ti_api
jedcunningham Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion airflow/api_connexion/endpoints/task_instance_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,9 @@ def get_task_instances_batch(session: Session = NEW_SESSION) -> APIResponse:
),
isouter=True,
).add_columns(SlaMiss)
ti_query = base_query.options(joinedload(TI.rendered_task_instance_fields))
ti_query = base_query.options(
joinedload(TI.rendered_task_instance_fields), joinedload(TI.task_instance_note)
)
# using execute because we want the SlaMiss entity. Scalars don't return None for missing entities
task_instances = session.execute(ti_query).all()

Expand Down
Loading