Javascript connection form will apply CodeMirror to all textarea's dynamically #39812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… textarea's being decorated as CodeMirror except the description field. That way, when additional textarea's are being added as widget's for a connection type, the CodeMirror widget will be applied.
dabla
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
jscheffl
approved these changes
Jun 1, 2024
bbovenzi
approved these changes
Jun 1, 2024
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
…namically (apache#39812) * refactor: Changed the javascript for the connection form to allow all textarea's being decorated as CodeMirror except the description field. That way, when additional textarea's are being added as widget's for a connection type, the CodeMirror widget will be applied. * refactor: Do not apply CodeMirror on hidden textArea's * refactor: Changed is hidden string from single quoted to double quoted --------- Co-authored-by: David Blain <[email protected]>
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…namically (apache#39812) * refactor: Changed the javascript for the connection form to allow all textarea's being decorated as CodeMirror except the description field. That way, when additional textarea's are being added as widget's for a connection type, the CodeMirror widget will be applied. * refactor: Do not apply CodeMirror on hidden textArea's * refactor: Changed is hidden string from single quoted to double quoted --------- Co-authored-by: David Blain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All textarea's within the connection form will be decorated as CodeMirror except the description field. That way, when additional textarea's are being added as widget's for a connection type, the CodeMirror widget will be applied to those as well.
This is a PR in preparation of #35591, as it has become to big, we're going to split it up in smaller ones. This is one of them.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.