Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve SA warnings in migrations scripts #39418

Merged
merged 1 commit into from
May 6, 2024

Conversation

Taragolis
Copy link
Contributor

{
  "category": "sqlalchemy.exc.RemovedIn20Warning",
  "message": "The legacy calling style of select() is deprecated and will be removed in SQLAlchemy 2.0.  Please use the new calling style described at select(). (Background on SQLAlchemy 2.0 at: [https://sqlalche.me/e/b8d9)",](https://sqlalche.me/e/b8d9)%22,)
  "filename": "airflow/migrations/versions/0102_2_3_0_switch_xcom_table_to_use_run_id.py",
  "lineno": 95,
  "when": "runtest",
  "node_id": "tests/integration/providers/qdrant/hooks/test_qdrant.py::TestQdrant::test_connection"
}
{
  "category": "sqlalchemy.exc.SAWarning",
  "message": "implicitly coercing SELECT object to scalar subquery; please use the .scalar_subquery() method to produce a scalar subquery.",
  "filename": "airflow/migrations/versions/0093_2_2_0_taskinstance_keyed_to_dagrun.py",
  "lineno": 407,
  "when": "runtest",
  "node_id": "tests/auth/managers/test_base_auth_manager.py::TestBaseAuthManager::test_security_manager_return_default_security_manager"
}
{
  "category": "sqlalchemy.exc.SAWarning",
  "message": "implicitly coercing SELECT object to scalar subquery; please use the .scalar_subquery() method to produce a scalar subquery.",
  "filename": "airflow/migrations/versions/0104_2_3_0_migrate_rtif_to_use_run_id_and_map_index.py",
  "lineno": 105,
  "when": "runtest",
  "node_id": "tests/auth/managers/test_base_auth_manager.py::TestBaseAuthManager::test_security_manager_return_default_security_manager"
}
{
  "category": "sqlalchemy.exc.SAWarning",
  "message": "implicitly coercing SELECT object to scalar subquery; please use the .scalar_subquery() method to produce a scalar subquery.",
  "filename": "airflow/migrations/versions/0105_2_3_0_add_map_index_to_taskfail.py",
  "lineno": 101,
  "when": "runtest",
  "node_id": "tests/auth/managers/test_base_auth_manager.py::TestBaseAuthManager::test_security_manager_return_default_security_manager"
}

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis Taragolis added the full tests needed We need to run full set of tests for this PR to merge label May 5, 2024
@Taragolis Taragolis added this to the Airflow 2.9.2 milestone May 5, 2024
@Taragolis Taragolis closed this May 5, 2024
@Taragolis Taragolis reopened this May 5, 2024
@Taragolis Taragolis merged commit 5e58723 into apache:main May 6, 2024
69 of 92 checks passed
@Taragolis Taragolis deleted the migrations-sa-warnings branch May 6, 2024 22:02
RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
@utkarsharma2 utkarsharma2 added type:improvement Changelog: Improvements type:misc/internal Changelog: Misc changes that should appear in change log and removed type:improvement Changelog: Improvements labels Jun 3, 2024
ephraimbuddy pushed a commit that referenced this pull request Jun 4, 2024
utkarsharma2 pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:db-migrations PRs with DB migration full tests needed We need to run full set of tests for this PR to merge kind:documentation type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants