Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make audit log before/after filterable #39120

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

bbovenzi
Copy link
Contributor

Before we preset the audit log before and after fields with the task instance or dag run queued to end times. And the filter bars were disabled.

Now:

  • remove preset values since we do a better job of recording run_id and actions after the dag run, like marking as failed or adding a note, would be missing
  • allow a user to filter before and after times
  • remove the disabled task id and run id filter bars since the breadcrumb already shows that
Screenshot 2024-04-18 at 1 17 02 PM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.9.1 milestone Apr 18, 2024
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 18, 2024
@jscheffl
Copy link
Contributor

I tried to "use" the audit log and either I am tooo stupid (rarely have clicked there, maybe I'm a noob in this) but:

  • When clicking in one of the date fields and picking a date the filter is not applied.
  • Clicking or pressing enter to a different aera clears the previous selcted data
  • I tried to use multiple options of include/exclude filter and it always when using include generated empty results or in case of exclude no effect. Somehow I was not able to filter and I did not understand where I can filter for.

Might it be that with the changes something is broken?
Or is my browser failing? Ubuntu 22.04 x64, Firefox.

@bbovenzi
Copy link
Contributor Author

I tried to "use" the audit log and either I am tooo stupid (rarely have clicked there, maybe I'm a noob in this) but:

  • When clicking in one of the date fields and picking a date the filter is not applied.
  • Clicking or pressing enter to a different aera clears the previous selcted data
  • I tried to use multiple options of include/exclude filter and it always when using include generated empty results or in case of exclude no effect. Somehow I was not able to filter and I did not understand where I can filter for.

Might it be that with the changes something is broken? Or is my browser failing? Ubuntu 22.04 x64, Firefox.

Something like selected a Before date and adding an event name doesn't work for you?
Screenshot 2024-04-23 at 3 54 24 PM

@jscheffl
Copy link
Contributor

I tried to "use" the audit log and either I am tooo stupid (rarely have clicked there, maybe I'm a noob in this) but:

  • When clicking in one of the date fields and picking a date the filter is not applied.
  • Clicking or pressing enter to a different aera clears the previous selcted data
  • I tried to use multiple options of include/exclude filter and it always when using include generated empty results or in case of exclude no effect. Somehow I was not able to filter and I did not understand where I can filter for.

Might it be that with the changes something is broken? Or is my browser failing? Ubuntu 22.04 x64, Firefox.

Something like selected a Before date and adding an event name doesn't work for you? Screenshot 2024-04-23 at 3 54 24 PM

Did a regression on my Ubuntu 20.04 x64 LTS:

  • Firefox
    • Both Start/End date are not working. I can use the date picker but upon exit of the popup, date / time selection is reset
    • Event filter is working (when entering text, but no suggestions in the popup below, do I need to expect anything?)
  • Chromium
    • Date start/end selection is working.
    • Event filter is working (when entering text, but no suggestions in the popup below, do I need to expect anything?)

UPDATE! I beleieve I found the root cause... in Firefox it looks like:
image
--> The DATE Popup oly shows a date selection. After clicking on a date the time fields are filled with --:--:-- and when exiting the dtae selection is reset. If I change the time before leaving focus the filter is applied.

Difference in Chromium the popup is like... WITH date AND time:
image

@bbovenzi
Copy link
Contributor Author

You're right. Looks like datetime-local is not supported in firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1726108

We use it in a few places. So I might need to figure out a workaround in another PR

@bbovenzi
Copy link
Contributor Author

You're right. Looks like datetime-local is not supported in firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1726108

We use it in a few places. So I might need to figure out a workaround in another PR

PR: #39261 we can merge that one and then I'll rebase this PR

@bbovenzi bbovenzi merged commit a7e5510 into apache:main Apr 26, 2024
39 checks passed
@bbovenzi bbovenzi deleted the audit-log-filters branch April 26, 2024 19:15
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, with the fix in the other PR and re-basing it is now working :-D

@utkarsharma2 utkarsharma2 added the type:new-feature Changelog: New Features label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants