Consolidate grid collapse actions to a single full screen toggle #39070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
ryanahamilton,
ashb and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
There was a problem hiding this comment.
Overall I like it. I noticed a bug though - if you drag the grid view a bit wider, then full screen, it doesn't actually expand to the full screen:
The behavior when you've dragged the bar around a bit generally seems a little weird, but that's the most broken behavior imo.
Fixed the issues specifically with the full screen mode. I'll need to play around more to make resizing work better as a whole. |
jedcunningham
approved these changes
Apr 18, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
…che#39070) * Consolidate grid collapse actions to a single full screen toggle * Fix toggle full screen with grid view resizing
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
…che#39070) * Consolidate grid collapse actions to a single full screen toggle * Fix toggle full screen with grid view resizing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of ways to change screen sizes in the grid view. Its a bit of a mess. You can collapse/expand the filter bar, you can collapse/expand the grid view, you can collapse/expand the details view, and you can only toggle everything from the logs and graph views.
Instead:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.