check whether AUTH_ROLE_PUBLIC is set in check_authentication #39012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
Lee-W
added
the
full tests needed
Lee-W
force-pushed
the
fix-AUTH_ROLE_PUBLIC
branch
from
2509179
to
2a0e913
Compare
potiuk
approved these changes
Apr 15, 2024
eladkal
approved these changes
Apr 15, 2024
vincbeck
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #38900
Why
Currently, some of the web UI uses API endpoint to grep data. e.g., the following ones
This is because
check_authenticationblocks users without authentication. But whenAUTH_ROLE_PUBLICis set, it's possible that the public user have permission to do certain operation (including viewing those pages).What
This PR check whether
AUTH_ROLE_PUBLICis set. If so, it assumes it as a valid user. If theAUTH_ROLE_PUBLICrole does not have proper permission, the authorization step will still blocks the request.