Don't wait for lock on DagRun in mini scheduler #38914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should just bail if something else is already "minischeduling". We already catch OperationalError so there's nothing else we need to change for this.
ashb
approved these changes
Apr 11, 2024
|
This might have the inverse effect of putting more load on the scheduler as it might end up doing more task expansion |
jedcunningham
pushed a commit
that referenced
this pull request
Apr 26, 2024
We should just bail if something else is already "minischeduling". We already catch OperationalError so there's nothing else we need to change for this. Sometimes (e.g. with certain task mapping scenarios) many tasks from same dag run are trying to "minischedule" at the same time. If something else is already locking, it's probably better to just move on and not wait. (cherry picked from commit afe8e82)
56 tasks
2 tasks
2 tasks
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should just bail if something else is already "minischeduling". We already catch OperationalError so there's nothing else we need to change for this.
@collinmcnulty and @jedcunningham you might be interested in this. Discovered in collaboration with @seanmuth that this can cause an issue if many tasks from same dag run are trying to "minischedule" at the same time. E.g. task mapping. If something else is already locking, we should just move on and not wait.