-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon Bedrock - Model Customization Jobs #38693
Amazon Bedrock - Model Customization Jobs #38693
Conversation
I also didn't add a BedrockDeleteCustomModelOperator because it is literally just a hook call: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work, I love all the optimizations we've made with supporting deferrable operators (AwsBaseWaiterTrigger
, custom waiters, consistent structures etc.) Really simplifies the whole process 😄
@o-nikolas @Taragolis @syedahsn - I refactored how we handle a name conflict. Can you please have another look and re-approve (or comment) when you get time? |
The code looks functionally correct to me. Although the |
@o-nikolas Reworked the |
Adds support for Model Customization Jobs. Includes changes to the hook(s), new Operator, Sensor, Trigger, Waiter, unit tests for the above, updates to the doc page, and additions to the system test.
Manually tested in Breeze using (wait_for_completion=False with a Sensor), wait_for_completion=True, and deferrable=True. Don't mind the first two, bugs were squashed , as seen in the rest of the runs :P