Mark more fields on API as dump-only #38616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
area:API
potiuk
approved these changes
Mar 29, 2024
jscheffl
force-pushed
the
bugfix/mark-more-api-fields-dump-only
branch
from
78bdca7
to
9198893
Compare
eladkal
approved these changes
Mar 31, 2024
jedcunningham
approved these changes
Mar 31, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 31, 2024
(cherry picked from commit 35d1899)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #38446 there was one review comment that the changes on task_instance_schema.py were missing the field
dump_only.Thereby I realized that the
dump_only=Trueis set inconsistent across most of the API schema definition.This PR aligns the definitions so that
dump_only=Trueis used commonly.