Ensure __exit__ is called in decorator context managers #38383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In apache#36800 author fixed zombie scheduler issue arising from context manager exit not being called, thus sub process not getting terminated. It was fixed by explicitly calling the `close` function on an ExitStack-managed context manager. Simpler / better / cleaner / more standard solution is to "fix" the underlying context managers by wrapping the yield in a try / finally.
vincbeck
approved these changes
Mar 21, 2024
Taragolis
approved these changes
Mar 21, 2024
potiuk
approved these changes
Mar 21, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
In apache#36800 author fixed zombie scheduler issue arising from context manager exit not being called, thus sub process not getting terminated. It was fixed by explicitly calling the `close` function on an ExitStack-managed context manager. Simpler / better / cleaner / more standard solution is to "fix" the underlying context managers by wrapping the yield in a try / finally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #36800 author fixed zombie scheduler issue arising from context manager exit not being called, thus sub process not getting terminated. It was fixed by explicitly calling the
closefunction on an ExitStack-managed context manager. Simpler / better / cleaner / more standard solution is to "fix" the underlying context managers by wrapping the yield in a try / finally.cc @joaopamaral