Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visible DagRun doesn't point to the same dag run id #38365

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix visible DagRun doesn't point to the same dag run id #38365

merged 2 commits into from
May 16, 2024
+5 −5

Conversation

lotrias17
Copy link
Contributor

As stated by @nivdror, displaying a DAG RUN date different from the dag run id may cause confusion to users. I fixed this by changing the default displayed date to the Interval Start Date instead of Interval End Date.

closes: #35946

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 21, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Mar 21, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal changed the title Fix #35946: Visible DAG RUN doesn't point to the same dag run id Fix visible DagRun doesn't point to the same dag run id Mar 23, 2024
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Mar 23, 2024
@eladkal eladkal added this to the Airflow 2.9.0 milestone Mar 23, 2024
jscheffl
jscheffl approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this looks good but I am only 90% certain if this is "right". @bbovenzi Can you double check before merge?

@lotrias17 @eladkal
Fix apache#35946: Visible DAG RUN doesn't point to the same dag run id
a1a1b1d 
As stated by @nivdror, displaying a DAG RUN date different from
the dag run id may cause confusion to users. I fixed this by
changing the default displayed date to the Interval Start Date
instead of Interval End Date.
@jedcunningham
Copy link
Member

Gentle bump @bbovenzi. I do wonder if both places should use logical_date instead though.

@bbovenzi
Copy link
Contributor

Let's go for logical date then

@lotrias17
Copy link
Contributor Author

Is there anything I should add or change?

@lotrias17
Copy link
Contributor Author

Is there anything I could contribute to help merge this Pull Request?

@jscheffl jscheffl merged commit 4dce745 into apache:main May 16, 2024
39 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented May 16, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

RNHTTR pushed a commit to RNHTTR/airflow that referenced this pull request Jun 1, 2024
@lotrias17 @uranusjr @RNHTTR
Fix apache#35946: Visible DAG RUN doesn't point to the same dag run id (
01c07a0 
apache#38365)

As stated by @nivdror, displaying a DAG RUN date different from
the dag run id may cause confusion to users. I fixed this by
changing the default displayed date to the Interval Start Date
instead of Interval End Date.

Co-authored-by: Tzu-ping Chung <[email protected]>
ephraimbuddy pushed a commit that referenced this pull request Jun 4, 2024
@lotrias17 @ephraimbuddy
Fix #35946: Visible DAG RUN doesn't point to the same dag run id (#38365
fbcf2bf 
)

As stated by @nivdror, displaying a DAG RUN date different from
the dag run id may cause confusion to users. I fixed this by
changing the default displayed date to the Interval Start Date
instead of Interval End Date.

Co-authored-by: Tzu-ping Chung <[email protected]>
(cherry picked from commit 4dce745)
ephraimbuddy pushed a commit that referenced this pull request Jun 5, 2024
@lotrias17 @ephraimbuddy
Fix #35946: Visible DAG RUN doesn't point to the same dag run id (#38365
83e8e74 
)

As stated by @nivdror, displaying a DAG RUN date different from
the dag run id may cause confusion to users. I fixed this by
changing the default displayed date to the Interval Start Date
instead of Interval End Date.

Co-authored-by: Tzu-ping Chung <[email protected]>
(cherry picked from commit 4dce745)
utkarsharma2 pushed a commit that referenced this pull request Jun 5, 2024
@lotrias17 @utkarsharma2
Fix #35946: Visible DAG RUN doesn't point to the same dag run id (#38365
59a7a73 
)

As stated by @nivdror, displaying a DAG RUN date different from
the dag run id may cause confusion to users. I fixed this by
changing the default displayed date to the Interval Start Date
instead of Interval End Date.

Co-authored-by: Tzu-ping Chung <[email protected]>
(cherry picked from commit 4dce745)
ephraimbuddy pushed a commit that referenced this pull request Jun 5, 2024
@lotrias17 @ephraimbuddy
Fix #35946: Visible DAG RUN doesn't point to the same dag run id (#38365
9db34af 
)

As stated by @nivdror, displaying a DAG RUN date different from
the dag run id may cause confusion to users. I fixed this by
changing the default displayed date to the Interval Start Date
instead of Interval End Date.

Co-authored-by: Tzu-ping Chung <[email protected]>
(cherry picked from commit 4dce745)
@utkarsharma2 utkarsharma2 mentioned this pull request Jun 6, 2024
Closed
41 tasks
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
@lotrias17 @uranusjr @romsharon98
Fix apache#35946: Visible DAG RUN doesn't point to the same dag run id (
62e5e77 
apache#38365)

As stated by @nivdror, displaying a DAG RUN date different from
the dag run id may cause confusion to users. I fixed this by
changing the default displayed date to the Interval Start Date
instead of Interval End Date.

Co-authored-by: Tzu-ping Chung <[email protected]>
@tirkarthi tirkarthi mentioned this pull request Aug 1, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taragolis Taragolis Taragolis approved these changes

@jscheffl jscheffl jscheffl approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.9.2
Development

Successfully merging this pull request may close these issues.

Visible DAG RUN doesn't point to the same dag run id
8 participants
@lotrias17 @jedcunningham @bbovenzi @Taragolis @jscheffl @ephraimbuddy @eladkal @uranusjr