-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI support for bulk pause and resume of DAGs #38265
Conversation
b9761e6
to
e5aa9ac
Compare
e5aa9ac
to
0d6a43f
Compare
0d6a43f
to
db3a942
Compare
509bf86
to
afa2bb6
Compare
afa2bb6
to
dc3bee0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like unpausing a single dag is now broken by this PR. I have not tested bulk pause/unpause but for one dag, it seems broken
Ok. It now errors when the dag is paused and you are pausing again. I think it should just exit without error if DAG is already paused
Apologies for the confusion, maybe raising an error for pausing an already paused dag (and vice versa) is indeed too aggressive - I'll try to come up with a fix later on. |
Added the change here: #38585. Take a look when you have time |
…sing (#40345) closes: #38834 #38265 added bulk pause and resume of DAGs. However, this PR seems to reuse the cli util method that collects DAGs from the default dag folder but not from the metadata DB. Hence, this would cause the unpause command to fail on environments where the dag folder is missing.
…sing (#40345) closes: #38834 #38265 added bulk pause and resume of DAGs. However, this PR seems to reuse the cli util method that collects DAGs from the default dag folder but not from the metadata DB. Hence, this would cause the unpause command to fail on environments where the dag folder is missing. (cherry picked from commit e3d62c3)
…sing (#40345) closes: #38834 #38265 added bulk pause and resume of DAGs. However, this PR seems to reuse the cli util method that collects DAGs from the default dag folder but not from the metadata DB. Hence, this would cause the unpause command to fail on environments where the dag folder is missing. (cherry picked from commit e3d62c3)
…sing (#40345) closes: #38834 #38265 added bulk pause and resume of DAGs. However, this PR seems to reuse the cli util method that collects DAGs from the default dag folder but not from the metadata DB. Hence, this would cause the unpause command to fail on environments where the dag folder is missing. (cherry picked from commit e3d62c3)
…sing (apache#40345) closes: apache#38834 apache#38265 added bulk pause and resume of DAGs. However, this PR seems to reuse the cli util method that collects DAGs from the default dag folder but not from the metadata DB. Hence, this would cause the unpause command to fail on environments where the dag folder is missing.
closes: #36956
This PR adds the ability for
airflow dags (un)pause
commands to treatdag_id
as a regex (similar tobackfill
), so we could apply it to multiple DAGs.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.