Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding max consecutive failed dag runs info in UI #38229

Merged

Conversation

pateash
Copy link
Contributor

@pateash pateash commented Mar 17, 2024

closes: #38171
related: #36935

Description
We have added ability to automatically turn off DAG after X number of consecutive failures.

We should also highlight/show this information to user as this will affect their DAG runs,
I am adding information in DAG in UI,
this will only be shown in the DAGs which have this feature enabled.

Before the Change

image

After the Change

image

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 17, 2024
@pateash
Copy link
Contributor Author

pateash commented Mar 17, 2024

FYI: @eladkal

@pateash pateash changed the title 38171 adding max consecutive failed dag runs in UI Adding max consecutive failed dag runs info in UI Mar 17, 2024
Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pateash
Nice to see this information. UI Experts can review it.

@bbovenzi
Copy link
Contributor

I would prefer we access this through the REST APU and show it in the DAG "Details" panel here.

@pateash pateash force-pushed the 38171-Adding-max_consecutive_failed_dag_runs-in-UI branch 2 times, most recently from 287f6b7 to a996c41 Compare March 19, 2024 07:48
@pateash
Copy link
Contributor Author

pateash commented Mar 19, 2024

I would prefer we access this through the REST APU and show it in the DAG "Details" panel here.

@bbovenzi its already present in Dag details.
IMO this is very important information as it affect the dag runs( auto pauses the dag ),
and should be available upfront. happy to know your thought.

we can also use info icon (will only be shown if auto pausing enabled in DAG) if that makes sense.

image image

@pateash pateash requested a review from dirrao March 19, 2024 09:46
@bbovenzi
Copy link
Contributor

its already present in Dag details. IMO this is very important information as it affect the dag runs( auto pauses the dag ), and should be available upfront. happy to know your thought.

we can also use info icon (will only be shown if auto pausing enabled in DAG) if that makes sense.

Ok. Let's keep the icon you had. Let's just make it gray and then lgtm.

@pateash pateash force-pushed the 38171-Adding-max_consecutive_failed_dag_runs-in-UI branch from cd1a705 to 14d9b40 Compare March 20, 2024 05:11
@pateash
Copy link
Contributor Author

pateash commented Mar 20, 2024

its already present in Dag details. IMO this is very important information as it affect the dag runs( auto pauses the dag ), and should be available upfront. happy to know your thought.
we can also use info icon (will only be shown if auto pausing enabled in DAG) if that makes sense.

Ok. Let's keep the icon you had. Let's just make it gray and then lgtm.

thanks @bbovenzi changed as suggested

image

@eladkal eladkal added this to the Airflow 2.9.0 milestone Mar 20, 2024
@eladkal eladkal added the type:misc/internal Changelog: Misc changes that should appear in change log label Mar 20, 2024
@eladkal eladkal merged commit 5139776 into apache:main Mar 20, 2024
44 checks passed
@pateash pateash deleted the 38171-Adding-max_consecutive_failed_dag_runs-in-UI branch March 21, 2024 04:20
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding max_consecutive_failed_dag_runs in UI for dag
4 participants