Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cryptography to > 39.0.0 #38112

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 13, 2024

We had a very old cryptography version specified as min requirement. Bumping cryptography to 39.0.0 (released Jan 2023) should help with better resolutions and should keep Airflow secure.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We had a very old cryptography version specified as min requirement.
Bumping cryptography to 39.0.0 (released Jan 2023) should help with
better resolutions and should keep Airflow secure.
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One qn, its a major bump, are we sure it wont break anything?

I mean Ci will catch it, so we are good

@potiuk
Copy link
Member Author

potiuk commented Mar 13, 2024

LGTM. One qn, its a major bump, are we sure it wont break anything?

It's just minium version. Everyone who installs airfllow from cratch gets latest version - also in the constraints we have 41.0.7 version for a long time https://github.com/apache/airflow/blob/constraints-main/constraints-3.8.txt#L267

I checked, it was 40+ version already in Airflow 2.6.3

cryptography==40.0.2

So no, no worries :)

@potiuk
Copy link
Member Author

potiuk commented Mar 13, 2024

I mean Ci will catch it, so we are good

In CI nothing will change as we have 41.07 already :)

@potiuk potiuk merged commit 118def8 into apache:main Mar 13, 2024
95 of 96 checks passed
@potiuk potiuk deleted the bump-cryptography-min-version branch March 13, 2024 15:10
drajguru pushed a commit to drajguru/airflow that referenced this pull request Mar 14, 2024
We had a very old cryptography version specified as min requirement.
Bumping cryptography to 39.0.0 (released Jan 2023) should help with
better resolutions and should keep Airflow secure.
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Mar 14, 2024
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 18, 2024
We had a very old cryptography version specified as min requirement.
Bumping cryptography to 39.0.0 (released Jan 2023) should help with
better resolutions and should keep Airflow secure.
howardyoo pushed a commit to howardyoo/airflow that referenced this pull request Mar 31, 2024
We had a very old cryptography version specified as min requirement.
Bumping cryptography to 39.0.0 (released Jan 2023) should help with
better resolutions and should keep Airflow secure.
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
We had a very old cryptography version specified as min requirement.
Bumping cryptography to 39.0.0 (released Jan 2023) should help with
better resolutions and should keep Airflow secure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants