-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Cryptography to > 39.0.0 #38112
Conversation
We had a very old cryptography version specified as min requirement. Bumping cryptography to 39.0.0 (released Jan 2023) should help with better resolutions and should keep Airflow secure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One qn, its a major bump, are we sure it wont break anything?
I mean Ci will catch it, so we are good
It's just minium version. Everyone who installs airfllow from cratch gets latest version - also in the constraints we have 41.0.7 version for a long time https://github.com/apache/airflow/blob/constraints-main/constraints-3.8.txt#L267 I checked, it was 40+ version already in Airflow 2.6.3 Line 244 in e514f90
So no, no worries :) |
In CI nothing will change as we have 41.07 already :) |
We had a very old cryptography version specified as min requirement. Bumping cryptography to 39.0.0 (released Jan 2023) should help with better resolutions and should keep Airflow secure.
We had a very old cryptography version specified as min requirement. Bumping cryptography to 39.0.0 (released Jan 2023) should help with better resolutions and should keep Airflow secure.
We had a very old cryptography version specified as min requirement. Bumping cryptography to 39.0.0 (released Jan 2023) should help with better resolutions and should keep Airflow secure.
We had a very old cryptography version specified as min requirement. Bumping cryptography to 39.0.0 (released Jan 2023) should help with better resolutions and should keep Airflow secure.
We had a very old cryptography version specified as min requirement. Bumping cryptography to 39.0.0 (released Jan 2023) should help with better resolutions and should keep Airflow secure.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.