Don't log "403" from worker serve-logs as "Unknown error". #37933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you make a request to `http://localhost:8793/` it would get denied
from this block on L82:
```python
auth = request.headers.get("Authorization")
if auth is None:
logger.warning("The Authorization header is missing: %s.", request.headers)
abort(403)
``
abort is internally implemented to raise an exception. However since
that `abort()` call was inside a try/except block, it was getting caught
under the `execpt Exception:` fallback and running this:
```
except Exception:
logger.warning("Unknown error", exc_info=True)
abort(403)
```
So nothing was wrong with the behaviour (it still 403d the request),
it's just the logs were slightly confusing.
jedcunningham
approved these changes
Mar 7, 2024
potiuk
approved these changes
Mar 7, 2024
howardyoo
pushed a commit
to howardyoo/airflow
that referenced
this pull request
Mar 18, 2024
) If you make a request to `http://localhost:8793/` it would get denied from this block on L82: ```python auth = request.headers.get("Authorization") if auth is None: logger.warning("The Authorization header is missing: %s.", request.headers) abort(403) `` abort is internally implemented to raise an exception. However since that `abort()` call was inside a try/except block, it was getting caught under the `execpt Exception:` fallback and running this: ``` except Exception: logger.warning("Unknown error", exc_info=True) abort(403) ``` So nothing was wrong with the behaviour (it still 403d the request), it's just the logs were slightly confusing.
howardyoo
pushed a commit
to howardyoo/airflow
that referenced
this pull request
Mar 31, 2024
) If you make a request to `http://localhost:8793/` it would get denied from this block on L82: ```python auth = request.headers.get("Authorization") if auth is None: logger.warning("The Authorization header is missing: %s.", request.headers) abort(403) `` abort is internally implemented to raise an exception. However since that `abort()` call was inside a try/except block, it was getting caught under the `execpt Exception:` fallback and running this: ``` except Exception: logger.warning("Unknown error", exc_info=True) abort(403) ``` So nothing was wrong with the behaviour (it still 403d the request), it's just the logs were slightly confusing.
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
) If you make a request to `http://localhost:8793/` it would get denied from this block on L82: ```python auth = request.headers.get("Authorization") if auth is None: logger.warning("The Authorization header is missing: %s.", request.headers) abort(403) `` abort is internally implemented to raise an exception. However since that `abort()` call was inside a try/except block, it was getting caught under the `execpt Exception:` fallback and running this: ``` except Exception: logger.warning("Unknown error", exc_info=True) abort(403) ``` So nothing was wrong with the behaviour (it still 403d the request), it's just the logs were slightly confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you make a request to
http://localhost:8793/it would get denied from this block on L82:abort is internally implemented to raise an exception. However since that
abort()call was inside a try/except block, it was getting caught under theexecpt Exception:fallback and running this:So nothing was wrong with the behaviour (it still 403d the request), it's just the logs were slightly confusing.