make default helm annotations optional on extra cm and secrets #37893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudeepgupta90
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
romsharon98
approved these changes
Apr 16, 2024
| {{- toYaml $configMapContent.annotations | nindent 4 }} | ||
| {{- end }} | ||
| {{- $annotations := dict }} | ||
| {{- if $configMapContent.useHelmHooks }} |
There was a problem hiding this comment.
If we do this, we must do it in such a way that we fall back to true if not specified for backcompat. And have test coverage for it.
|
Thanks for the PR @sudeepgupta90! This has been added in #40294. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make default helm hook annotations on extra configmaps and secrets to be optional. Currently, they are always enabled, and there's no way to turn them off. This aligns the chart with similar pattern as observed in the
db-migrationsandcreate-userjob. The user however will now have to specify explicitly if they want add the hooks or not with theuseHelmHooksin the manifest as boolean values can not be defaulted^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.