Ensure "airflow.task" logger used for TaskInstancePydantic and TaskInstance #37857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…skInstance Airflow TIs are assumed to log to the "airflow.task" logger. TaskInstance was configuring this in the "reconstructor", a sqlalchemy thing that is processed on loading from DB. But there's no equivalent for Pydantic models, and when running a task with TaskInstancePydantic, the wrong logger was used (fully qualified class name). When looking for a solution, I saw that LoggingMixin will check `_logger_name` and if set will use it. This works for the pydantic model and seems better for TI anyway so I updated both.
dstandish
requested review from
kaxil,
ashb,
bolkedebruin and
XD-DENG
as code owners
dstandish
changed the title
dstandish
changed the title
dirrao
approved these changes
Mar 3, 2024
potiuk
approved these changes
Mar 3, 2024
eladkal
approved these changes
Mar 3, 2024
utkarsharma2
added
type:improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Airflow TIs are assumed to log to the "airflow.task" logger. TaskInstance was configuring this in the "reconstructor", a sqlalchemy thing that is processed on loading from DB. But there's no equivalent for Pydantic models, and when running a task with TaskInstancePydantic, the wrong logger was used (fully qualified class name). When looking for a solution, I saw that LoggingMixin will check
_logger_nameand if set will use it. This works for the pydantic model and seems better for TI anyway so I updated both.