-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate smtp configs in airflow settings / local_settings #37711
Deprecate smtp configs in airflow settings / local_settings #37711
Conversation
airflow/providers/smtp/notifications/templates/email_subject.jinja
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also would be nice to have a test with a custom values which comes thought configs.
Just in case, it could be done by a conf_vars
context manager
Also I think we should release 1.6.1 NOT 1.7.0. Technically it will be a bugfix to buggy feature added it 1.6.0. Even if we yank 1.6.0, this one is still adding the same feature already added in 1.6.* (only properly). |
cb466f6
to
8bdc24c
Compare
Should be good to go @eladkal |
closes: #37703
This removes the usage of
airflow/settings.py
|airflow_local_settings.py
from the templated SmtpNotifier.Ensure emails still come through as expected:
Using this test dag:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.