Add migration for rendered_map_index column in task_instance table. #37708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Feb 26, 2024
airflow/migrations/versions/0134_2_9_0_add_rendered_map_index_to_taskinstance.py
Outdated
Show resolved
Hide resolved
tirkarthi
force-pushed
the
add-migration
branch
from
6d31c74
to
8aca98f
Compare
jedcunningham
approved these changes
Feb 27, 2024
|
Didn't we have a test to ensure migrations and models always build the same db? Wonder when that broke... |
We never had those. We have a migration test that runs the migration up and down - but we never compared if the result is the same as the Models we have. |
potiuk
approved these changes
Feb 27, 2024
|
Just a watch-out - we have two migrations in-progress. I think we have a protection that will make the secon one not mergable if the first is but there will be some re-work needed once the other mighration is merged. #37731 |
|
It’s interesting to me this does not show up in tests that use |
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
ephraimbuddy
added
the
changelog:skip
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add migration for rendered_map_index column added to task_instance table in PR #36797
related: #36797