-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refrain from passing encoding
to the SQL engine in SQLAlchemy v2
#37545
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
@potiuk Pinging as promised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appproved - with a potential NIT
Eh this is not what I suggested, I want the SQLA v1 check to go into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @uranusjr -> we should move it to airflow.uitls.sqlalchemy
LGTM. @uranusjr ? |
Can someone please explain the build failure to me? I don't know what to do about it. |
This error is expected, regression of #37524 |
Well - it was you who proposed to do something common between pydantic and sqlachemy so you expanded scope and discussions yourself, so yes it took longer and had more twists. I thinl up until then there was only one extra suggestion from TP so that you move things to sqlalchemy. If you need exact instructions here it is:
And yes, it happens and is expected. Sometimes small prs takes days or weeks and you will get different twists along the way and people looking at what you propose will have different opinions. And sometimes it get few iterations. |
As of the latest changes (submitted a few hours ago), both of the points you mentioned are implemented. Is it acceptable to resolve the threads (assuming the changes were implemented, of course; I'm just used to letting the reviewer "close the loop")? |
...merge? |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…pache#37545) * Fix broken hyperlink to Dockerfile.ci * Fix typo, add PY311 to main init's exports * Add util for checking package versions * Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 * Fix an SQLA2 deprecation warning * Addressing PR comments
…pache#37545) * Fix broken hyperlink to Dockerfile.ci * Fix typo, add PY311 to main init's exports * Add util for checking package versions * Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 * Fix an SQLA2 deprecation warning * Addressing PR comments
This PR fixes 1 error and 1 warning related to SQLAlchemy v2 ("SQLA2"), as well as an unrelated documentation hyperlink issue.
See motivation for changes here: #28723 (comment)
related: #28723
Note that while the added unit tests pass on SQLA1, one of them fails with SQLA2, and will require additional future modifications before that version could be adopted:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.