Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to job heartbeat #37541

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Conversation

awdavidson
Copy link
Contributor

@awdavidson awdavidson commented Feb 19, 2024


Add retries to Job.heartbeat to avoid job SIGTERM due to intermittent/transient database issues. Raised in #37378

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Feb 19, 2024
Copy link

boring-cyborg bot commented Feb 19, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@awdavidson awdavidson marked this pull request as ready for review February 19, 2024 11:29
airflow/jobs/job.py Outdated Show resolved Hide resolved
airflow/jobs/job.py Outdated Show resolved Hide resolved
airflow/jobs/job.py Outdated Show resolved Hide resolved
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should split the retries - separately for fetch and separately for update

@potiuk potiuk added this to the Airflow 2.8.3 milestone Feb 26, 2024
@potiuk
Copy link
Member

potiuk commented Feb 26, 2024

I would love to have some more reviews on that one - to see if no-one can see a side effect (I believe it is safe to retry on the level of those methods.

@potiuk
Copy link
Member

potiuk commented Feb 28, 2024

Anyone :) ?

@potiuk potiuk merged commit 4ca45c7 into apache:main Mar 8, 2024
59 checks passed
Copy link

boring-cyborg bot commented Mar 8, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants