-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hook.wait_for_operation in DataprocInstantiateInlineWorkflowTemplateOperator #37145
Use hook.wait_for_operation in DataprocInstantiateInlineWorkflowTemplateOperator #37145
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
bd7d697
to
9fbf861
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the test case for the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
9fbf861
to
fc03f8b
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
We ran into an issue when running a long Dataproc job with
DataprocInstantiateInlineWorkflowTemplateOperator
. It seems thathook.wait_for_operation
should be used so that thetimeout
parameter is passed tooperation.result()
properly.The error we were getting: