Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SCHEDULED_DEPS which is no longer used anywhere since 2.0.0 #37140

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Feb 2, 2024

SCHEDULED_DEPS is no longer used anywhere in the codebase, since 2.0.0 (the last version where it was used is 1.10.15)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@dirrao dirrao added area:core area:Scheduler including HA (high availability) scheduler labels Feb 2, 2024
Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static checks are failing due to using unused import SCHEDULEABLE_STATES.

Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XD-DENG XD-DENG requested a review from dirrao February 2, 2024 05:36
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is not a part of the public API, removing it should be safe.

@hussein-awala hussein-awala added this to the Airflow 2.9.0 milestone Feb 2, 2024
@hussein-awala hussein-awala added the type:misc/internal Changelog: Misc changes that should appear in change log label Feb 2, 2024
@Taragolis Taragolis merged commit 44ba900 into apache:main Feb 4, 2024
57 checks passed
@XD-DENG XD-DENG deleted the remove-unused-deps branch February 5, 2024 16:55
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
…pache#37140)

* Remove SCHEDULED_DEPS which is no longer used anywhere since 2.0.0

* Fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core area:Scheduler including HA (high availability) scheduler type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants